Subsystem Isolation
Revision as of 15:45, 30 December 2012 by Tom Parker (talk | contribs)
This is a working document to show which items have NOT been isolated from PlayerCharacter, and considerations and issues which make that conversion non-trivial (meaning more than a 30-second job, not necessarily "difficult")
Prerequisites
- PreAbilityTester: Awaiting Ability (non-clone) rebuild
 - PreApplyTester: Awaiting TEMPBONUS proposal on _exp
 - PreAttackTester: Epic cache complexity
 - PreCheckBaseTester: Epic cache complexity
 - PreCheckTester: Epic cache complexity
 - PreClassTester: PlayerCharacter.isSpellCaster
 - PreCSkillTester: PlayerCharacter.isClassSkill (and why is a "CSKILL for any class" so widely used?)
 - PreEquipTester: Equipment.getEffectiveWieldCategory
 - PreFeatTester: Awaiting Ability (non-clone) rebuild
 - PreHPTester: PlayerCharacter.hitPoints
 - PreRuleTester: RECURSIVE? Sub-prerequisites?
 - PreSkillMultTester: SkillRankControl.getTotalRank (dependent on RankedSkillFacet.18890.patch)
 - PreSkillTester: SkillRankControl.getTotalRank (dependent on RankedSkillFacet.18890.patch)
 - PreSpecialAbilityTester: Consolidation of Special Abilities to one Facet
 - PreSpellDescriptorTester: PlayerCharacter.aggregateSpellList
 - PreSpellResistanceTester: PlayerCharacter.calcSR
 - PreSpellSchoolSubTester: PlayerCharacter.aggregateSpellList
 - PreSpellSchoolTester: PlayerCharacter.aggregateSpellList
 - PreSpellTester: PlayerCharacter.aggregateSpellList & PlayerCharacter.getAutoSpells
 - PreSpellTypeTester: PlayerCharacter.countSpellCastTypeLevel
 - PreUnarmedAttackTester: PCClass.baseAttackBonus (which depends on PCClass.getBonusTo ...)
 - PreVariableTester: PlayerCharacter.getVariableValue & Equipment.getVariableValue
 
Primitives
- Domain/Deity: Technically PrereqHandler, but should be rebuilt to have "domainsAllowedByDeity()" on PlayerCharacter
 - Equipment/Wield: WieldCategory.checkWield ... Equipment.getEffectiveWieldCategory
 - PObject/Feat: PlayerCharacter.getFeatNamedAnyCat (which is really Awaiting Ability (non-clone) rebuild)
 - Spell/All: PlayerCharacter.getPCBasedLevelInfo, PlayerCharacter.getCharacterSpells, Formula resolution
 - Spell/ClassList: SpellLevel.levelForKey, PlayerCharacter.getCharacterSpells, Formula resolution
 - Spell/DomainList: SpellLevel.levelForKey, PlayerCharacter.getCharacterSpells, Formula resolution
 - Spell/Prohibited: SpellCountCalc.isProhibited
 - Spell/SpellBook: PlayerCharacter.hasSpellInSpellBook
 - Spell/SpellType: PlayerCharacter.getPCBasedLevelInfo, PlayerCharacter.getCharacterSpells, Formula resolution